Make SchemaCache an opinionated default in HTTP handlers #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
SamMorrowDrums
approved these changes
Feb 11, 2026
Copilot
AI
changed the title
[WIP] Set schemacache as required for streamable HTTP server
Make SchemaCache an opinionated default in HTTP handlers
Feb 11, 2026
SamMorrowDrums
merged commit 0e71f57
into
sammorrowdrums/add-schema-cache-http
2 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR converts the SchemaCache from an optional configuration to an opinionated default by creating it directly in the NewHTTPMcpHandler constructor. This simplifies the API while ensuring the performance optimization is always present for the streamable HTTP server, which creates a new MCP server instance for each request.
Changes:
- Removed
WithSchemaCacheoption function andSchemaCachefield fromHandlerOptions - Moved schema cache instantiation from
RunHTTPServerintoNewHTTPMcpHandlerconstructor - Removed unused
mcpimport frompkg/http/server.go
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/http/server.go | Removed schema cache creation and WithSchemaCache option call; removed unused mcp import |
| pkg/http/handler.go | Removed SchemaCache field from HandlerOptions and WithSchemaCache option function; moved schema cache creation into NewHTTPMcpHandler constructor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SchemaCache is now always created in
NewHTTPMcpHandler, not passed as an option. Streamable HTTP servers always need schema caching for per-request MCP server creation.Why
Review feedback on #1993: schema cache isn't a config—it's an architectural requirement for HTTP mode. Making it optional adds complexity without value.
What changed
WithSchemaCacheoption function andSchemaCachefield fromHandlerOptionsNewHTTPMcpHandlerconstructorWithSchemaCachecall fromRunHTTPServerMCP impact
Internal refactor only—removes optional parameter that should always be set.
Prompts tested (tool changes only)
N/A
Security / limits
Tool renaming
Lint & tests
./script/lint./script/testDocs
Internal implementation change with no external API impact.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.