Skip to content

Add shared SchemaCache for streamable-http server #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 4 commits into from
Feb 11, 2026
+8 −1
Merged

Add shared SchemaCache for streamable-http server #1993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c648966
Add shared SchemaCache for streamable-http server
SamMorrowDrums Feb 11, 2026
1d2ad77
Fix lint CI: use Go 1.25 to match golangci-lint v2.5.0
Copilot Feb 11, 2026
487cf0b
Co-locate WithSchemaCache with other With functions
Copilot Feb 11, 2026
0e71f57
Make schema cache an opinionated default for HTTP handlers
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: stable
go-version: '1.25'
Copy link
Collaborator Author

@SamMorrowDrums SamMorrowDrums Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter requires this

- name: golangci-lint
uses: golangci/golangci-lint-action@v9
with:
Expand Down
7 changes: 7 additions & 0 deletions pkg/http/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ type Handler struct {
inventoryFactoryFunc InventoryFactoryFunc
oauthCfg *oauth.Config
scopeFetcher scopes.FetcherInterface
schemaCache *mcp.SchemaCache
}

type HandlerOptions struct {
Expand Down Expand Up @@ -101,6 +102,10 @@ func NewHTTPMcpHandler(
inventoryFactory = DefaultInventoryFactory(cfg, t, opts.FeatureChecker, scopeFetcher)
}

// Create a shared schema cache to avoid repeated JSON schema reflection
// when a new MCP Server is created per request in stateless mode.
schemaCache := mcp.NewSchemaCache()

return &Handler{
ctx: ctx,
config: cfg,
Expand All @@ -112,6 +117,7 @@ func NewHTTPMcpHandler(
inventoryFactoryFunc: inventoryFactory,
oauthCfg: opts.OAuthConfig,
scopeFetcher: scopeFetcher,
schemaCache: schemaCache,
}
}

Expand Down Expand Up @@ -195,6 +201,7 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
Resources: &mcp.ResourceCapabilities{},
Prompts: &mcp.PromptCapabilities{},
}
so.SchemaCache = h.schemaCache
},
},
})
Expand Down