Skip to content

Conversation

@tonytrg
Copy link
Contributor

@tonytrg tonytrg commented Jan 26, 2026

Summary

Why

Alignment of names

What changed

MCP impact

  • No tool or API changes
  • Tool schema or behavior changed
  • New tool added

Prompts tested (tool changes only)

Security / limits

  • No security or limits impact
  • Auth / permissions considered
  • Data exposure, filtering, or token/size limits considered

Tool renaming

  • I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
    • I have added the new tool aliases in deprecated_tool_aliases.go
  • I am not renaming tools as part of this PR

Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed
  • Updated (README / docs / examples)

@tonytrg tonytrg requested a review from a team as a code owner January 26, 2026 14:45
Copilot AI review requested due to automatic review settings January 26, 2026 14:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a naming inconsistency by renaming InsiderMode to InsidersMode throughout the codebase to align with the actual feature name "insiders mode" and its associated environment variable GITHUB_INSIDERS_MODE and flag --insiders-mode.

Changes:

  • Renamed the InsiderMode field to InsidersMode in the FeatureFlags struct and all configuration structs
  • Updated all references from insider-mode to insiders-mode in flags, viper bindings, and test helpers
  • Updated documentation in README.md and docs/remote-server.md to reflect the corrected naming

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/github/feature_flags.go Renamed struct field from InsiderMode to InsidersMode
pkg/github/server_test.go Updated test helper to use insiders-mode key
pkg/github/feature_flags_test.go Updated test code and variable names to use InsidersMode
internal/ghmcp/server.go Updated struct fields, comments, and usage of InsidersMode in both MCPServerConfig and StdioServerConfig
internal/ghmcp/server_test.go Updated test configuration to use InsidersMode
cmd/github-mcp-server/main.go Updated CLI flag from --insider-mode to --insiders-mode and all viper bindings
README.md Updated documentation examples to use --insiders-mode flag and GITHUB_INSIDERS_MODE environment variable
docs/remote-server.md Updated documentation reference from GITHUB_INSIDER_MODE to GITHUB_INSIDERS_MODE and --insider-mode to --insiders-mode

@tonytrg tonytrg changed the title adding correct insiders-mode name adding correct insiders name Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants