-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Default to consolidated actions/projects toolsets and add hold back flag #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR inverts the feature flag behavior for consolidated actions and projects toolsets, making them the default instead of opt-in. It introduces new "holdback" feature flags that allow reverting to individual tools when needed.
Changes:
- Introduces
FeatureFlagHoldbackConsolidatedActionsandFeatureFlagHoldbackConsolidatedProjectsas replacement flags - Swaps
FeatureFlagEnableandFeatureFlagDisableassignments across all actions and projects tools to make consolidated tools the default - Marks legacy
FeatureFlagConsolidatedActionsandFeatureFlagConsolidatedProjectsconstants as deprecated
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/github/actions.go | Introduces holdback flag and inverts feature flag logic for 15 individual actions tools (now enabled via holdback flag) and 4 consolidated actions tools (now disabled via holdback flag) |
| pkg/github/projects.go | Introduces holdback flag and inverts feature flag logic for 9 individual projects tools (now enabled via holdback flag) and 3 consolidated projects tools (now disabled via holdback flag) |
| // FeatureFlagConsolidatedProjects is the legacy feature flag (deprecated, no longer used). | ||
| // Kept for documentation purposes only. | ||
| const FeatureFlagConsolidatedProjects = "remote_mcp_consolidated_projects" | ||
|
|
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The legacy feature flag constant is marked as deprecated but is still exported and defined. Since this is used as a library by the remote server, consider whether this constant should remain exported or if it can be removed entirely. If it's still referenced elsewhere in the remote server codebase, keeping it is correct. Otherwise, consider removing it in a follow-up PR to reduce API surface.
| // FeatureFlagConsolidatedProjects is the legacy feature flag (deprecated, no longer used). | |
| // Kept for documentation purposes only. | |
| const FeatureFlagConsolidatedProjects = "remote_mcp_consolidated_projects" |
Summary
This pull request updates the feature flag logic for both GitHub Actions and Projects tools, introducing new "holdback" feature flags to control the use of consolidated versus individual tools. The legacy consolidated feature flags are now deprecated and only kept for documentation, while the new holdback flags actively control tool availability. The changes ensure that enabling a holdback flag reverts to individual tools, and the consolidated tools are now enabled by default unless the holdback flag is set.
Why
Fixes #
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs