fix(commands): remove IsHidden property from UseGithubStorage option#1522
fix(commands): remove IsHidden property from UseGithubStorage option#1522joshjohanning wants to merge 2 commits intogithub:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Exposes the --use-github-storage option in CLI help output now that GitHub-owned storage is generally available, aligning the gei and bbs2gh CLIs with current product availability.
Changes:
- Unhides
--use-github-storageingei migrate-repoandgei generate-script. - Unhides
--use-github-storageinbbs2gh migrate-repoandbbs2gh generate-script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs | Removes IsHidden so --use-github-storage appears in --help for gei migrate-repo. |
| src/gei/Commands/GenerateScript/GenerateScriptCommand.cs | Removes IsHidden so --use-github-storage appears in --help for gei generate-script. |
| src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs | Removes hidden initializer so --use-github-storage appears in --help for bbs2gh migrate-repo. |
| src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs | Removes IsHidden so --use-github-storage appears in --help for bbs2gh generate-script. |
| @@ -108,7 +108,6 @@ public MigrateRepoCommand() : base( | |||
| }; | |||
| public Option<bool> UseGithubStorage { get; } = new("--use-github-storage") | |||
| { | |||
There was a problem hiding this comment.
This is a user-visible CLI change (the --use-github-storage flag will now appear in --help). Per the contribution guidelines, user-noticeable changes should include a bullet in RELEASENOTES.md; please add an entry describing that this option is no longer hidden / is now generally available.
| { | |
| { | |
| IsHidden = true, |
Unit Test Results 1 files 1 suites 10m 25s ⏱️ Results for commit 06be10c. ♻️ This comment has been updated with latest results. |
|
ThirdPartyNotices.txt(if applicable)Description
Now that GitHub-owned storage is generally available, we shouldn't hide it when running
--help.