Render report_incomplete reasons in agent failure comment and issue templates#33087
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing {report_incomplete_context} placeholder in agent failure templates
Render report_incomplete reasons in agent failure comment and issue templates
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures agent report_incomplete reasons are surfaced in rendered failure comments/issues (instead of being silently dropped) and adds a regression test to prevent reoccurrence.
Changes:
- Added
{report_incomplete_context}toagent_failure_comment.mdandagent_failure_issue.mdin the existing context ordering. - Added a focused template-rendering regression test to assert
report_incompletereason text appears in both rendered outputs. - Regenerated
.github/workflows/pr-description-caveman.lock.yml(large workflow lockfile update).
Show a summary per file
| File | Description |
|---|---|
| actions/setup/md/agent_failure_issue.md | Adds {report_incomplete_context} placeholder so incomplete-run reasons appear in failure issues. |
| actions/setup/md/agent_failure_comment.md | Adds {report_incomplete_context} placeholder so incomplete-run reasons appear in failure comments. |
| actions/setup/js/handle_agent_failure.test.cjs | Adds regression coverage by rendering real templates and asserting the reason text is present. |
| .github/workflows/pr-description-caveman.lock.yml | Large lockfile regeneration with many workflow/runtime/version/step changes beyond the template fix. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 1
Comment on lines
+1
to
5
| # gh-aw-metadata: {"schema_version":"v3","frontmatter_hash":"d323adc7f9e87e820faddb72dc94b0db9f74299868e4ca982ddcecc4a4edc777","strict":true,"agent_id":"copilot"} | ||
| # gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GITHUB_TOKEN"],"actions":[{"repo":"actions/checkout","sha":"de0fac2e4500dabe0009e67214ff5f5447ce83dd","version":"v6.0.2"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/cli-proxy:0.25.46"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.25.46"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.9","digest":"sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.9@sha256:64828b42a4482f58fab16509d7f8f495a6d97c972a98a68aff20543531ac0388"},{"image":"ghcr.io/github/github-mcp-server:v1.0.4"},{"image":"node:lts-alpine","digest":"sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f","pinned_image":"node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f"}]} | ||
| # ___ _ _ | ||
| # / _ \ | | (_) | ||
| # | |_| | __ _ ___ _ __ | |_ _ ___ |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_agent_failure.cjsalready buildsreport_incomplete_context, but bothagent_failure_comment.mdandagent_failure_issue.mdomitted the placeholder, so the agent’s incomplete-run reason was silently discarded from rendered output. This change wires that context through the templates and adds coverage for the regression.Template fix
{report_incomplete_context}to both failure templates in the existing context ordering, between{permission_denied_context}and{missing_safe_outputs_context}.Regression coverage
report_incompletecontext and asserts the reason text is present in both outputs.renderTemplate()to silently drop the value without test failure.Rendered behavior
{permission_denied_context}{report_incomplete_context}{missing_safe_outputs_context}With a
report_incompleteitem such as:{ "type": "report_incomplete", "reason": "cannot continue" }the rendered failure comment/issue now includes the agent’s stated reason instead of only generic boilerplate.