Shared: Improvements to SensitiveDataHeuristics.qll#21806
Draft
geoffw0 wants to merge 10 commits intogithub:mainfrom
Draft
Shared: Improvements to SensitiveDataHeuristics.qll#21806geoffw0 wants to merge 10 commits intogithub:mainfrom
geoffw0 wants to merge 10 commits intogithub:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of a series of small improvements to
SensitiveDataHeuristics.qll, intended to find more true and less false sources of sensitive data. One of these changes addresses a request from a user, the rest are motivated by issues we've spotted at various points in the past. None are expected to have a big impact by themselves (but 7 changes x 5 affected languages is quite a lot of surface area).card.?no,api.?tok,security.?codepatterns. We already had similar cases but no exact coverage for these.wildcard_nois notcard.?no;profileis notfile;cauthoris notoauth.security_codefor containingcode. It was also handlingunencryptedincorrectly - whileunencryptwas not matched due to the special case, thecryptsubstring was matched due to the entireunenpart of the regex being optional. Copilot gets most of the credit for spotting this one.Draft PR because I need to: