Open
Conversation
redsun82
added
the
depends on internal PR
Collaborator
|
redsun82
removed
the
depends on internal PR
redsun82
changed the title
rules_kotlin to v2.3.10rules_kotlin to v2.3.20
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s vendored Bazel registry entry for rules_kotlin to a newer upstream release, including the CodeQL-specific patch set used when building Kotlin components with Bazel/bzlmod.
Changes:
- Bumps the
rules_kotlinmodule version referenced by the repo and registry metadata. - Adds a new
rules_kotlinversion directory with updatedsource.json(URL/integrity) and patch hashes. - Updates the vendored
rules_kotlinMODULE.bazeldependency set for the new upstream version.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| misc/bazel/registry/modules/rules_kotlin/metadata.json | Updates the registry’s available rules_kotlin version list. |
| misc/bazel/registry/modules/rules_kotlin/2.3.20.codeql.1/source.json | Adds the new upstream source URL/integrity and patch references. |
| misc/bazel/registry/modules/rules_kotlin/2.3.20.codeql.1/patches/codeql_do_not_emit_jdeps.patch | Carries forward the CodeQL patch to disable jdeps emission by default. |
| misc/bazel/registry/modules/rules_kotlin/2.3.20.codeql.1/patches/codeql_add_language_version_option.patch | Carries forward the CodeQL patch to add a Kotlin language/API version option mapping. |
| misc/bazel/registry/modules/rules_kotlin/2.3.20.codeql.1/MODULE.bazel | Updates the vendored module definition/dependencies for the new version. |
| misc/bazel/registry/modules/rules_kotlin/2.2.2-codeql.1/source.json | Removes the old version’s source definition (as part of the version bump). |
| MODULE.bazel | Bumps the repo’s rules_kotlin dependency to the new version. |
Comments suppressed due to low confidence (1)
misc/bazel/registry/modules/rules_kotlin/2.3.20.codeql.1/MODULE.bazel:4
version = "2.3.20.codeql.1"is inconsistent with the-codeql.1suffix used by other CodeQL-patched modules in this registry (for examplemisc/bazel/registry/modules/fmt/12.1.0-codeql.1andmisc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1). Consider switching to2.3.20-codeql.1for consistency (and update metadata/root dependencies accordingly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.