Rust: Call refactor follow-up fixes #20967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/call-refactor-fix
branch
from
d760dac to
be1d756
Compare
hvitved
commented
Dec 4, 2025
| OperationMethodCall() { super.isOverloaded(_, _, _) } | ||
|
|
||
| override Expr getPositionalArgument(int i) { result = super.getOperand(i + 1) } | ||
| override Expr getPositionalArgument(int i) { result = super.getOperand(i + 1) and i >= 0 } |
Contributor
Author
There was a problem hiding this comment.
This does not actually matter in practice, since TPositionalArgumentPosition limits positions to be non-negative, however it still makes sense to fix.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a performance bug that was introduced in a previous call refactor PR. The bug was caused by using the instanceof pattern instead of multiple inheritance in QL class definitions.
- Changed
CallExprMethodCallfrom usinginstanceofrestriction to proper multiple inheritance - Added defensive constraint
i >= 0togetPositionalArgumentinOperationMethodCall - Updated test expectations to reflect the corrected dataflow behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/elements/internal/CallExprImpl.qll | Changed CallExprMethodCall from instanceof pattern to multiple inheritance (, separator) to fix performance issue |
| rust/ql/lib/codeql/rust/elements/internal/OperationImpl.qll | Added i >= 0 constraint to getPositionalArgument for defensive bounds checking |
| rust/ql/test/library-tests/dataflow/sources/net/InlineFlow.expected | Updated test expectations to remove spurious dataflow edges that were incorrectly generated before the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally merged #20863 a bit too quick; the DCA experiment I ran after addressing review comments revealed a performance bug, which was caused by this change.