Skip to content

Rust: Remove some predicates #20963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Dec 5, 2025
+1 −13
Merged

Rust: Remove some predicates #20963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions rust/ql/lib/codeql/rust/elements/internal/CallExprImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ module Impl {
override string toStringImpl() { result = this.getFunction().toAbbreviatedString() + "(...)" }

override Expr getSyntacticPositionalArgument(int i) { result = getSyntacticArg(this, i) }

// todo: remove once internal query has been updated
Expr getArg(int i) { result = getSyntacticArg(this, i) }

// todo: remove once internal query has been updated
int getNumberOfArgs() { result = this.getNumberOfSyntacticArguments() }
}

/**
Expand Down
8 changes: 1 addition & 7 deletions rust/ql/lib/codeql/rust/elements/internal/CallImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ module Impl {
/** Gets an argument of this call. */
Expr getAnArgument() { result = this.getArgument(_) }

// todo: remove once internal query has been updated
Expr getReceiver() { none() }

/**
* Gets the `i`th positional argument of this call.
*
Expand Down Expand Up @@ -71,9 +68,6 @@ module Impl {
/** Gets the name of the function called, if any. */
string getTargetName() { result = this.getStaticTarget().getName().getText() }

// todo: remove once internal query has been updated
string getMethodName() { result = this.getTargetName() }

/** Gets a runtime target of this call, if any. */
pragma[nomagic]
Function getARuntimeTarget() {
Expand Down Expand Up @@ -110,6 +104,6 @@ module Impl {
* x[y]; // `x` is receiver
* ```
*/
override Expr getReceiver() { none() }
Expr getReceiver() { none() }
}
}