Go: Reinstate dummy test so consistency tests are run #20949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38cb6e5.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous commit to reinstate a dummy test file that ensures consistency checks are executed for the Go language tests. Without this dummy query, the test framework would not run the consistency checks in go/ql/test/consistency/, leaving the UnexpectedFrontendErrors.expected file unvalidated.
- Reinstates
dummy.qlwith a minimal query that triggers test execution - Adds corresponding
dummy.expectedfile with the expected query output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/ql/test/consistency/dummy.ql | Adds a simple dummy query that outputs a string to ensure the test framework processes this directory |
| go/ql/test/consistency/dummy.expected | Adds the expected output for the dummy query |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 38cb6e5.
This is needed so that the consistency checks are run on
go/ql/test/consistency/, otherwise we don't check thatgo/ql/test/consistency/CONSISTENCY/UnexpectedFrontendErrors.expectedis correct.