Adjust query severity ratings #20671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts security severity ratings for several queries across multiple languages to better align with their actual security impact. The XSS query is upgraded while OverlyLargeRange and insecure cookie queries are downgraded.
- Increased
js/xss-through-domseverity from 6.1 to 7.8 to align with other XSS queries - Reduced
overly-large-rangequery severity from 5.0 to 4.0 across Java, JavaScript, Python, and Ruby - Reduced
java/insecure-cookieseverity from 5.0 to 4.0
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/ql/src/Security/CWE-079/XssThroughDom.ql | Increased security severity from 6.1 to 7.8 |
| javascript/ql/src/Security/CWE-020/OverlyLargeRange.ql | Reduced security severity from 5.0 to 4.0 |
| python/ql/src/Security/CWE-020/OverlyLargeRange.ql | Reduced security severity from 5.0 to 4.0 |
| ruby/ql/src/queries/security/cwe-020/OverlyLargeRange.ql | Reduced security severity from 5.0 to 4.0 |
| java/ql/src/Security/CWE/CWE-020/OverlyLargeRange.ql | Reduced security severity from 5.0 to 4.0 |
| java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql | Reduced security severity from 5.0 to 4.0 |
| javascript/ql/src/change-notes/2025-10-22-adjust-query-severity.md | Documents XSS and OverlyLargeRange severity changes for JavaScript |
| python/ql/src/change-notes/2025-10-22-adjust-query-severity.md | Documents OverlyLargeRange severity change for Python |
| ruby/ql/src/change-notes/2025-10-22-adjust-query-severity.md | Documents OverlyLargeRange severity change for Ruby |
| java/ql/src/change-notes/2025-10-22-adjust-query-severity.md | Documents OverlyLargeRange and insecure-cookie severity changes for Java |
Contributor
|
Please can you list the motivation for changing these in the PR description, so it can be easily found in future. |
asgerf
approved these changes
Nov 11, 2025
owen-mc
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js/xss-through-domto align with the severity levels of other XSS queries.OverlyLargeRangequery ratings, as this is primarily a code quality issue; an overly large range rarely leads to a direct security vulnerability.java/insecure-cookieseverity because, with widespread HTTPS adoption and stricter browser security, missing the secure flag on cookies now poses minimal real-world risk.