Go: mistyped-exponentiation: notice constants with likely-bitmask values #20523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the mistyped-exponentiation query in Go to better detect XOR operations that might be mistaken for exponentiation by including constants with likely bitmask values in the detection logic.
- Adds support for detecting XOR operations involving declared constants that have hexadecimal or octal initializers
- Updates the test case to include constant declarations with hexadecimal values to verify the enhanced detection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/ql/src/InconsistentCode/MistypedExponentiation.ql | Adds helper function to resolve constant initializers and extends bitmask pattern detection to include constants |
| go/ql/test/query-tests/InconsistentCode/MistypedExponentiation/main.go | Adds test case with hexadecimal constants to verify the enhanced query behavior |
Contributor
Author
|
@owen-mc done |
owen-mc
approved these changes
Sep 25, 2025
owen-mc
requested changes
Sep 25, 2025
Contributor
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
Oh wait, this is a quality query. No change note then. Sorry for misinformation earlier.
owen-mc
approved these changes
Sep 26, 2025
Contributor
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
I realised I could delete the change note myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.