C++: Remove the BMN filter from some queries, but reduce precision to medium #20410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… medium
Remove the `not any(Compilation c).buildModeNone() and` clause from:
cpp/wrong-type-format-argument
cpp/comparison-with-wider-type
cpp/integer-multiplication-cast-to-long
cpp/implicit-function-declaration
cpp/suspicious-add-sizeof
but reduce their precision to `medium`.
igfoo
force-pushed
the
igfoo/bmn-med
branch
from
5dadbb7 to
b3f4c68
Compare
igfoo
added
the
depends on internal PR
Queries affected:
cpp/wrong-type-format-argument
cpp/comparison-with-wider-type
cpp/integer-multiplication-cast-to-long
cpp/implicit-function-declaration
cpp/suspicious-add-sizeof
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the BMN (Build Mode None) filter from five C++ CodeQL queries while reducing their precision from "high" to "medium". The changes enable these queries to now run on projects built with build-mode: none but at a lower confidence level.
- Removes
not any(Compilation c).buildModeNone() andclause from 5 queries - Changes precision metadata from
@precision highto@precision medium - Updates query suites to exclude 4 of these queries from code-scanning
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/src/change-notes/2025-09-11-queries-demoted.md | Documents the precision reduction and suite changes for affected queries |
| cpp/ql/src/Security/CWE/CWE-468/SuspiciousAddWithSizeof.ql | Removes BMN filter and reduces precision to medium |
| cpp/ql/src/Security/CWE/CWE-190/ComparisonWithWiderType.ql | Removes BMN filter and reduces precision to medium |
| cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql | Removes BMN filter and reduces precision to medium |
| cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql | Removes BMN filter and reduces precision to medium |
| cpp/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql | Removes BMN filter and reduces precision to medium |
| cpp/ql/integration-tests/query-suite/cpp-code-scanning.qls.expected | Removes 4 queries from the code-scanning suite |
| category: majorAnalysis | ||
| --- | ||
| * The queries `cpp/wrong-type-format-argument`, `cpp/comparison-with-wider-type`, `cpp/integer-multiplication-cast-to-long`, `cpp/implicit-function-declaration` and `cpp/suspicious-add-sizeof` have had their precisions reduced from `high` to `medium`. They will also now give alerts for projects built with `build-mode: none`. | ||
| * The queries `cpp/wrong-type-format-argument`, `cpp/comparison-with-wider-type`, `cpp/integer-multiplication-cast-to-long` and `cpp/suspicious-add-sizeof` are no longer included in the `code-scanning` suite. |
There was a problem hiding this comment.
The change note lists only 4 queries as being removed from the code-scanning suite, but the description mentions 5 queries total. The cpp/implicit-function-declaration query is missing from this list, though it appears this query was never in the code-scanning suite to begin with. Consider clarifying this discrepancy or adding a note that cpp/implicit-function-declaration was not previously included in the suite.
Suggested change
| * The queries `cpp/wrong-type-format-argument`, `cpp/comparison-with-wider-type`, `cpp/integer-multiplication-cast-to-long` and `cpp/suspicious-add-sizeof` are no longer included in the `code-scanning` suite. | |
| * The queries `cpp/wrong-type-format-argument`, `cpp/comparison-with-wider-type`, `cpp/integer-multiplication-cast-to-long` and `cpp/suspicious-add-sizeof` are no longer included in the `code-scanning` suite. | |
| * Note: `cpp/implicit-function-declaration` was not previously included in the `code-scanning` suite. |
jketema
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
not any(Compilation c).buildModeNone() andclause from:but reduce their precision to
medium.