Rust: Assign locations to all DataFlowCallables
#20351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes location assignment for DataFlowCallable objects in Rust by ensuring that both CFG-based and library-based callables have proper location information. Previously, only CFG scope callables had location information assigned.
Key changes:
- Extended the
getLocation()method forDataFlowCallableto include locations from summarized callables - Updated test expectations to handle external locations properly
- Added post-processing for external location formatting in tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| viableCallable.qlref | Added external location post-processing to test configuration |
| viableCallable.expected | Updated expected test output to show {EXTERNAL LOCATION} for external functions |
| DataFlowImpl.qll | Extended getLocation() method to return locations for both CFG and summarized callables |
paldepind
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.