Rust: Clean up some odds and ends #20167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sinks (probably inherited from another query or language where it is used).
…ent with similar queries.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs minor cleanup tasks across the Rust security analysis codebase to improve maintainability and consistency. The changes focus on documentation clarity, simplifying pattern matching, and standardizing alert messages.
- Updated QLDoc for the
sinkModelpredicate to be more maintainable by removing hardcoded examples - Simplified pattern matching in
CleartextLoggingExtensions.qllby removing unnecessary wildcards - Reworded alert message for
rust/cleartext-transmissionto match consistent formatting
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/query-tests/security/CWE-311/CleartextTransmission.expected | Updated expected test output to reflect new alert message format |
| rust/ql/src/queries/security/CWE-311/CleartextTransmission.ql | Changed alert message from "The operation" to "This operation" format |
| rust/ql/lib/codeql/rust/security/CleartextLoggingExtensions.qll | Simplified pattern matching by removing wildcard usage |
| rust/ql/lib/codeql/rust/dataflow/internal/ModelsAsData.qll | Updated documentation to be more maintainable and less specific |
hvitved
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some odds and ends:
sinkModelpredicate.CleartextLoggingExtensions.qll.rust/cleartext-transmissionto be more consistent with similar Rust and non-Rust queries.