Rust: Update BadCtorInitialization.ql to use getCanonicalPath. #20150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
added
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BadCtorInitialization.ql query to use getCanonicalPath() instead of getResolvedCrateOrigin() for identifying standard library calls. The change aims to improve the reliability of detecting calls to the Rust standard library by using canonical paths with pattern matching rather than crate origin resolution.
- Replaces
getResolvedCrateOrigin()calls withgetCanonicalPath().matches()pattern matching - Consolidates two separate conditions for
CallExprandMethodCallExprinto a single condition usingCallExprBase - Uses pattern matching to detect standard library paths with prefixes "std::" and "<std::"
hvitved
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
BadCtorInitialization.qlto usegetCanonicalPath()rather thangetResolvedCrateOrigin().getStaticTarget(), but results are otherwise identical (that is, we don't lose any due to thematchesexpression failing).