Skip to content

Conversation

@redsun82
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 20, 2025 14:59
@redsun82 redsun82 requested a review from a team as a code owner June 20, 2025 14:59
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jun 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to resolve test flakiness by updating the pinned libc version and corresponding expected outputs in the CWE-770 path resolution consistency tests.

  • Bump libc dependency to version 0.2.174 for qltest
  • Adjust expected crate version lines from 0.2.173 → 0.2.172 in the consistency test

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
rust/ql/test/query-tests/security/CWE-770/options.yml Updated the libc version in qltest_dependencies.
rust/ql/test/query-tests/security/CWE-770/CONSISTENCY/PathResolutionConsistency.expected Modified expected crate version references in output.
Comments suppressed due to low confidence (1)

rust/ql/test/query-tests/security/CWE-770/options.yml:3

  • The consistency test expects two versions of libc (0.2.172 and 0.2.174), but only 0.2.174 is declared here. Either add libc = { version = "0.2.172" } to qltest_dependencies or update the expected file to match a single version.
    - libc = { version = "0.2.174" }

@redsun82 redsun82 merged commit 3ddecd4 into main Jun 20, 2025
14 checks passed
@redsun82 redsun82 deleted the redsun82/rust-fix-test-flakiness branch June 20, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants