Rust: Avoid overlapping path resolution consistency checks #19825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/path-resolution-consistency-remove-overlap
branch
5 times, most recently
from
7b01e95 to
5150f78
Compare
hvitved
force-pushed
the
rust/path-resolution-consistency-remove-overlap
branch
from
5150f78 to
1f09f71
Compare
geoffw0
reviewed
Jun 23, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Tests for inconsistencies look much less noisy - a big improvement.
I'd like to see DCA run as well (when this is out of draft).
Contributor
Author
I'll start one. But note that the restrictions to only consider paths in source code only applies to the test queries, not to the numbers computed in DCA, and I would like to keep it that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also restricts the inconsistencies reported in tests to paths that are in source code; but note that DCA inconsistency counts will still include non-source-code paths as well.