-
Notifications
You must be signed in to change notification settings - Fork 1.9k
JS: Mass promotion of queries to quality status
#19776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7686f1f to
69734a8
Compare
69734a8 to
0c31838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR promotes various JavaScript CodeQL queries to quality status by adding the @tags quality annotation and updating related tags, and updates the integration-tests suite to include all newly promoted queries.
- Bulk update: Added
@tags qualityand refined tag lists in Declarations, DOM, AngularJS, and other query modules. - Test suite update: Extended
javascript-code-quality.qls.expectedto cover all newly promoted queries.
Reviewed Changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/src/Declarations/* | Added @tags quality and adjusted tags on declaration queries |
| javascript/ql/src/DOM/* | Added @tags quality and refined tags on DOM queries |
| javascript/ql/src/AngularJS/* | Added @tags quality and refined tags on AngularJS queries |
| javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected | Updated expected suite list to include all promoted queries |
Comments suppressed due to low confidence (1)
javascript/ql/src/DOM/PseudoEval.ql:11
- The CWE identifier was changed from
cwe-676tocwe-67, which appears incorrect. Please restore the correct identifier (e.g.,external/cwe/cwe-676).
* external/cwe/cwe-67
owen-mc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 1 - more review to follow. I got as far as javascript/ql/src/Expressions/UnclearOperatorPrecedence.qhelp
owen-mc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished.
javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql
Outdated
Show resolved
Hide resolved
javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
Outdated
Show resolved
Hide resolved
Thank you for the helpful feedback! 🙇 |
owen-mc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, let's not spend too long debating tags.
This PR promotes multiple JavaScript queries by adding quality-related tags, clearly indicating their promotion to quality status.
Notes for reviewers:
js/loop-iteration-skipped-due-to-shiftingbecause it is currently being promoted in another pr JS: Promotejs/loop-iteration-skipped-due-to-shiftingto the Code Quality suite #19743