Skip to content

Rust: Add another type inference debug predicate #19728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Jun 12, 2025
Merged

Rust: Add another type inference debug predicate #19728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions rust/ql/lib/codeql/rust/internal/TypeInference.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,4 +1516,15 @@ private module Debug {
mce = getRelevantLocatable() and
result = resolveMethodCallTarget(mce)
}

pragma[nomagic]
private int countTypes(AstNode n, TypePath path, Type t) {
t = inferType(n, path) and
result = strictcount(Type t0 | t0 = inferType(n, path))
}

predicate maxTypes(AstNode n, TypePath path, Type t, int c) {
c = countTypes(n, path, t) and
c = max(countTypes(_, _, _))
Copy link

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling max over an unbounded countTypes(_, _, _) may lead to an expensive computation over all AST nodes and types. If this is purely for debugging, consider constraining the domain or caching results to reduce runtime cost.

Suggested change
c = max(countTypes(_, _, _))
c = max(countTypes(n0, path0, t0) |
n0 = getRelevantLocatable() and
path0 = path and
t0 = t
)

Copilot uses AI. Check for mistakes.
}
}