Python: Add Pandas SQLi sinks

[sylwia-budzynska]

Pandas has a read_sql sink, which allows for executing raw SQL queries with untrusted input. read_sql is a convenience method, that dispatches the query either to read_sql_table or read_sql_query. Please note that read_sql_table is not vulnerable to SQLi, but read_sql_query is.

Note that instead of adding new tests, I edited the previous tests, because they contained the vulnerable read_sql and read_sql_query method, which made them show up as failed.

[Copilot]

Pull Request Overview

This PR introduces explicit SQL injection modeling for pandas.read_sql and pandas.read_sql_query, updates existing tests to use an sqlite3 connection for sink detection, and adds a change note entry.

• Updated pandas DataFrame test to connect via sqlite3 and mark SQL sinks with $getSql.
• Added a ReadSQLCall QL class to flag raw SQL queries in Pandas.
• Documented the new analysis in the change notes.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
python/ql/test/library-tests/frameworks/pandas/dataframe_query.py	Replaced path-based calls with sqlite3.connect, updated sink markers
python/ql/src/change-notes/2025-05-26-pandas-sqli-sinks.md	Added entry for Pandas SQLi sinks
python/ql/lib/semmle/python/frameworks/Pandas.qll	Introduced ReadSQLCall to model read_sql and read_sql_query as sinks

Comments suppressed due to low confidence (2)

python/ql/test/library-tests/frameworks/pandas/dataframe_query.py:59

• This test covers positional arguments but does not cover keyword argument usage (e.g., sql= and con=). Adding a test for pd.read_sql_query(sql="...", con=connection) would ensure named-parameter sinks are detected.

df = pd.read_sql_query("sql query", connection) # $getSql="sql query"

python/ql/lib/semmle/python/frameworks/Pandas.qll:161

• Unconditionally treating read_sql as a sink may flag safe read_sql_table calls (which read_sql can dispatch to). Consider refining the model to only treat calls that route to read_sql_query or inspect argument patterns to avoid false positives.

ReadSQLCall() { this = API::moduleImport("pandas").getMember(["read_sql", "read_sql_query"]).getACall() }

[tausbn]

Short and sweet! Looks good to me. 👍

[sylwia-budzynska]

Thanks @tausbn ! I fixed some nitpicks from automation :)

[tausbn]

Thank you for the additional fixes! 🙂

[sylwia-budzynska]

Hi @tausbn I don't have the rights to merge, this one is ready from my side :)