-
Notifications
You must be signed in to change notification settings - Fork 1.9k
C/CPP: Update FlowSources to add wmain #19510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for wide-character entry points by treating wmain the same as main for argv flow sources.
- Update doc comment to mention
wmain - Extend
ArgvSourceto includewmainin itshasGlobalNamecheck
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com>
|
@jketema Thanks for fixing that silly mistake, must have deleted it while updating it |
jketema
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I do like to run an DCA experiment on this before merging. I'll start one now.
|
I won't be able to merge this PR once ready, can you do that for me @jketema |
This is to add support for applications with the wide-character version of the
mainfunction.https://learn.microsoft.com/en-us/cpp/c-language/using-wmain?view=msvc-170