Skip to content

Conversation

@codeql-ci
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings May 13, 2025 21:14
@codeql-ci codeql-ci requested review from a team as code owners May 13, 2025 21:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@smowton smowton merged commit 4bb829e into codeql-cli-2.21.3 May 13, 2025
14 checks passed
@smowton smowton deleted the release-prep/2.21.3 branch May 13, 2025 21:22

### Minor Analysis Improvements

* Changed the precision of the `cs/equality-on-floats` query from medium to high.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will result in it becoming part of the code-scanning suite automatically, is that right @smowton ?

Copy link
Contributor

@michaelnebel michaelnebel May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not get added to code-scanning suite due to the change in precision, as it is not tagged as a security query.
The query was added to the code-quality suite here.


### New Features

* Added AST nodes `UnsafeCastExpr`, `TypeValueExpr`, `IntegerType`, and `BuiltinFixedArrayType` that correspond to new nodes added by Swift 6.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What impact could this have on the results of analysing swift files @smowton ?

Copy link
Contributor

@jketema jketema May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None. TypeValueExpr, IntegerType, and BuiltinFixedArrayType are experimental Swift features that cannot really be used as far as I can tell, and UnsafeCastExpr is just another kind an implicit conversion, and implicit conversions we already supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants