Rust: Update query severities #19449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the severity levels of two Rust QL security queries to better align with their intended visibility in Code Scanning.
- Promote
rust/uncontrolled-allocation-sizefromrecommendationtowarning. - Demote
rust/cleartext-loggingfromerrortowarning.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/src/queries/security/CWE-770/UncontrolledAllocationSize.ql | Changed @problem.severity to warning. |
| rust/ql/src/queries/security/CWE-312/CleartextLogging.ql | Changed @problem.severity to warning. |
paldepind
approved these changes
May 12, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Looks great to me! Nice to align rust/cleartext-logging and rust/cleartext-transmission.
Contributor
Author
|
100%. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update query severities:
rust/uncontrolled-allocation-sizetowarning(recommendationwas unreasonably low; this change will cause the query to appear in the code scanning suite, as originally intended).rust/cleartext-loggingtowarning(the same asrust/cleartext-transmission, which I think has this right).