JS: Improved modeling of aws-sdk
#19364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
asgerf
requested changes
Apr 28, 2025
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
Have you tried with a sinkModel like this?
- `["aws-sdk", "", "AnyMember.Argument[0].Member[secretAccessKey]", "credentials-key"]
- `["aws-sdk", "", "Member[Credentials].Argument[1]", "credentials-key"]As discussed offline, secret scanning should cover this in practice so we shouldn't spend much time on it. I was going to suggest merging it anyway if it was a simple change as there can be other use-cases for recognising non-constant credential sinks. I'm just not sure why it was done like this. Perhaps we should just quickly move on from this one.
asgerf
approved these changes
Apr 28, 2025
…global credentials and AWS.Credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for detecting specific patterns in the use of
aws-sdkrelated to hardcoded credentials. The following cases are now identified:AWS.configobject with hardcoded credentials.AWS.ServiceNameinstances while passing hardcoded credentials.AWS.Credentialsobject.