Skip to content

C++: Support C23 typeof and typeof_unqual #19290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jketema merged 5 commits into from
Apr 24, 2025
Merged

C++: Support C23 typeof and typeof_unqual #19290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df3282c
C++: Support C23 `typeof` and `typeof_unqual`
jketema Apr 11, 2025
e97f949
C++: Update expected test results
jketema Apr 11, 2025
a3e0c15
C++: Add upgrade and downgrade scripts
jketema Apr 17, 2025
0c31346
C++: Update stats file
jketema Apr 22, 2025
cad6958
C++: Add change note
jketema Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cpp/downgrades/9a7c3c14c1076f64b871719117a558733d987b48/decltypes.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
class Type extends @type {
string toString() { none() }
}

class Expr extends @expr {
string toString() { none() }
}

from Type decltype, Expr expr, Type basetype, boolean parentheses
where decltypes(decltype, expr, _, basetype, parentheses)
select decltype, expr, basetype, parentheses
Comment on lines +1 to +11
Copy link
Contributor

@redsun82 redsun82 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this kind of projection can be written directly in the properties file by means of the reorder operator, without writing a ql file:

decltypes.rel: reorder decltypes.rel (int id, int expr, int kind, int basetype, boolean paren) id expr basetype paren

Copy link
Contributor Author

@jketema jketema Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this as is, but I'll keep this in mind when it ever comes up again.

19 changes: 19 additions & 0 deletions cpp/downgrades/9a7c3c14c1076f64b871719117a558733d987b48/derivedtypes.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
class Type extends @type {
string toString() { none() }
}

predicate derivedType(Type type, string name, int kind, Type type_id) {
derivedtypes(type, name, kind, type_id)
}

predicate typeTransformation(Type type, string name, int kind, Type type_id) {
type_operators(type, _, _, type_id) and
name = "" and
Copy link
Contributor

@redsun82 redsun82 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this name = "" means losing some information, but we're accepting that, right?

Copy link
Contributor Author

@jketema jketema Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. I'm just projecting all the rows of the type_operators table on the derivedtypes table, to make sure I have some kind of type, but the derivedtypes table requires me to make up some kind of name.

Copy link
Contributor Author

@jketema jketema Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could compute something based on the two columns of type_operators that I ignore here, but that doesn't seem to be worth the trouble.

kind = 3 // @type_with_specifiers
}

from Type type, string name, int kind, Type type_id
where
derivedType(type, name, kind, type_id) or
typeTransformation(type, name, kind, type_id)
select type, name, kind, type_id
Loading