JS: Model as Data open package
#19256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds model-as-data support for the "open" package to address potential path injection issues by extending CodeQL's JavaScript sink model. Key changes include:
- Adding a new test file for the "open" package demonstrating its use.
- Introducing a new model file (open.model.yml) to provide sink definitions.
- Including a change note for documentation of the update.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/open.js | Adds test cases triggering alerts for the "open" and "openApp" functions. |
| javascript/ql/lib/ext/open.model.yml | Introduces sink model data for the "open" package to detect path injection. |
| javascript/ql/lib/change-notes/2025-04-07-open-package.md | Documents the minor analysis update for supporting the "open" package. |
Files not reviewed (1)
- javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/TaintedPath.expected: Language not supported
asgerf
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added model as data for
openpackage.