C++: Parameters can have a static specifier but are not static #19221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be a problem once we output those specifiers in the extractor.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test case to verify that parameters with a static specifier are processed correctly by the extractor.
- Added a new test function, static_array_param, that uses a static array parameter.
- Updated the test file (cpp/ql/test/library-tests/ir/ir/c11.c) to include this scenario.
Files not reviewed (4)
- cpp/ql/lib/semmle/code/cpp/Parameter.qll: Language not supported
- cpp/ql/test/library-tests/ir/ir/PrintAST.expected: Language not supported
- cpp/ql/test/library-tests/ir/ir/aliased_ir.expected: Language not supported
- cpp/ql/test/library-tests/ir/ir/raw_ir.expected: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
MathiasVP
reviewed
Apr 4, 2025
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM if DCA is happy (and someone else from the team also thinks it LGTT - "looks good to them"? 😂)
Contributor
Author
|
DCA looks good. |
Contributor
Author
|
Closing for now, as we likely need a different solution in the extractor that will also works for the - somewhat related - nullability attributes from clang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a problem once we output those specifiers in the extractor.
Also add a test with such a static specifier.