JS: Modeling of rimraf functions
#19196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the modeling of rimraf functions to improve path-injection analysis by adding support for additional methods.
- Updated tests to include calls to various rimraf methods as sinks.
- Extended the sink model in the YAML configuration to cover both synchronous and asynchronous rimraf methods.
- Added change notes documenting the support for additional rimraf methods.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/rimraf.js | Added tests invoking multiple rimraf methods to simulate potential path-injection sinks. |
| javascript/ql/lib/ext/rimraf.model.yml | Extended modeling definitions to cover new rimraf method variations. |
| javascript/ql/lib/change-notes/2025-04-02-rimraf.md | Added change note highlighting the new support for additional rimraf methods. |
Files not reviewed (1)
- javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/TaintedPath.expected: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
asgerf
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MaD for
rimraffunctions which were not covered.