C++: Add class representing calling conventions #19159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
force-pushed
the
idrissrio/calling-conventions
branch
3 times, most recently
from
c4cae31 to
86786fc
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for calling convention updates in C++ functions by adding tests and a change note.
- Added tests for calling conventions in C++ functions
- Added a change note for calling convention support
Files not reviewed (4)
- cpp/ql/lib/semmle/code/cpp/Specifier.qll: Language not supported
- cpp/ql/test/library-tests/calling-convention/calling-convention.expected: Language not supported
- cpp/ql/test/library-tests/calling-convention/calling-convention.ql: Language not supported
- cpp/ql/test/library-tests/calling-convention/test.cpp: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
IdrissRio
force-pushed
the
idrissrio/calling-conventions
branch
from
86786fc to
67b4713
Compare
IdrissRio
changed the title
jketema
reviewed
Apr 1, 2025
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
LGTM. I think we can make the change note a bit more precise though.
IdrissRio
force-pushed
the
idrissrio/calling-conventions
branch
from
67b4713 to
d61d973
Compare
jketema
approved these changes
Apr 1, 2025
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
LGTM. No need to run DCA on this, as the new code is not used by any of our queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallingConventionSpecifierto represent calling conventions in C++ functions.