JS: Refactor markdown-table library modeling
#18964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This pull request refactors the markdown-table library modeling to use a flow summary, ensuring that ArrayElement elements are unfolded correctly.
- Introduces a new YAML configuration file for the markdown-table model.
- Adds corresponding change note documentation.
- Updates an inline comment in a security test case.
Reviewed Changes
| File | Description |
|---|---|
| javascript/ql/lib/ext/markdown-table.model.yml | Adds the new model configuration for markdown-table. |
| javascript/ql/lib/change-notes/2025-03-10-js-refactor-markdown-table.md | Documents the refactor with a change note. |
| javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXss.js | Updates inline comment by removing outdated FIXME text. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
asgerf
reviewed
Mar 10, 2025
javascript/ql/lib/change-notes/2025-03-10-js-refactor-markdown-table.md
Outdated
Show resolved
Hide resolved
…-table.md Co-authored-by: Asger F <asgerf@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the
markdown-tablemodel to a flow summary to ensureArrayElementis unfolded correctly.