Go: Add BasicBlock.getLocation
#18805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
go/basic-block-location
branch
3 times, most recently
from
4101601 to
ce267e9
Compare
hvitved
force-pushed
the
go/basic-block-location
branch
from
ce267e9 to
f72e1f6
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Contributor
|
Thanks for making this @hvitved . In the end I've decided to change the location of basic blocks to be a db location, so this approach isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
BasicBlock.getLocation. In order to create synthetic location entities for basic blocks, care must be taken to not add a dependency on the data flow layer, since data flow nodes also synthesize locations. The solution is to create separate class layers for (1) DB locations only, (2) DB or basic block locations, and (3) DB, or basic block, or data flow node locations.