JS: upgrade TypeScript to 5.8 #18798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR aims to upgrade TypeScript support by updating the type-checking configurations and related documentation.
- Update the change notes to reflect the new TypeScript version.
- Add a new markdown file documenting the upgrade.
Reviewed Changes
| File | Description |
|---|---|
| javascript/ql/lib/change-notes/2025-02-17-typescript-5-8.md | Adds a change note intended to document the upgrade to TypeScript 5.8, but incorrectly mentions TypeScript 5.5. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
asgerf
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the changes are additional type-checking, or optional features that are only relevant under specific flags.
No new syntax or other changes that seem to be relevant for our work.
See the announcement blogpost: https://devblogs.microsoft.com/typescript/announcing-typescript-5-8/
I'm running some DCA evaluations to confirm that everything is fine.