-
Notifications
You must be signed in to change notification settings - Fork 1.9k
JS: Migrate model of URLSearchParams #18768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
javascript/ql/lib/semmle/javascript/internal/flow_summaries/UrlSearchParams.qll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /** | ||
| * Contains a summary for `URLSearchParams` and `URL` objects. | ||
| * | ||
| * For now, the `URLSearchParams` object is modeled as a `Map` object. | ||
| */ | ||
|
|
||
| private import javascript | ||
|
|
||
| DataFlow::SourceNode urlConstructorRef() { result = DataFlow::globalVarRef("URL") } | ||
|
|
||
| DataFlow::SourceNode urlSearchParamsConstructorRef() { | ||
| result = DataFlow::globalVarRef("URLSearchParams") | ||
| } | ||
|
|
||
| class URLSearchParams extends DataFlow::SummarizedCallable { | ||
| URLSearchParams() { this = "URLSearchParams" } | ||
|
|
||
| override DataFlow::InvokeNode getACallSimple() { | ||
| result = urlSearchParamsConstructorRef().getAnInstantiation() | ||
| } | ||
|
|
||
| override predicate propagatesFlow(string input, string output, boolean preservesValue) { | ||
| // Taint the MapKey and MapValue so methods named 'get' and 'forEach' etc can extract the taint. | ||
| // Also taint the object itself since it has a tainted toString() value | ||
| input = "Argument[0]" and | ||
| output = ["ReturnValue", "ReturnValue.MapKey", "ReturnValue.MapValue"] and | ||
| preservesValue = false | ||
| } | ||
| } | ||
|
|
||
| class GetAll extends DataFlow::SummarizedCallable { | ||
| GetAll() { this = "getAll" } | ||
|
|
||
| override DataFlow::MethodCallNode getACallSimple() { | ||
| result.getMethodName() = "getAll" and result.getNumArgument() = 1 | ||
| } | ||
|
|
||
| override predicate propagatesFlow(string input, string output, boolean preservesValue) { | ||
| input = "Argument[this].MapValue" and | ||
| output = "ReturnValue.ArrayElement" and | ||
| preservesValue = true | ||
| } | ||
| } | ||
|
|
||
| class URLConstructor extends DataFlow::SummarizedCallable { | ||
github-advanced-security[bot] marked this conversation as resolved.
Dismissed
Show dismissed
Hide dismissed
|
||
| URLConstructor() { this = "URL" } | ||
|
|
||
| override DataFlow::InvokeNode getACallSimple() { | ||
| result = urlConstructorRef().getAnInstantiation() | ||
| } | ||
|
|
||
| override predicate propagatesFlow(string input, string output, boolean preservesValue) { | ||
| input = "Argument[0]" and | ||
| output = | ||
| [ | ||
| "ReturnValue.Member[searchParams].MapKey", | ||
| "ReturnValue.Member[searchParams].MapValue", | ||
| "ReturnValue.Member[searchParams,hash,search]", | ||
| ] and | ||
| preservesValue = false | ||
| } | ||
| } | ||
5 changes: 5 additions & 0 deletions
5
javascript/ql/src/change-notes/2025-02-13-url-search-params.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| category: fix | ||
| --- | ||
| * Fixed a recently-introduced bug that prevented taint tracking through `URLSearchParams` objects. | ||
| The original behaviour has been restored and taint should once again be tracked through such objects. |
15 changes: 15 additions & 0 deletions
15
javascript/ql/test/library-tests/TripleDot/urlsearchparams.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| function u1() { | ||
| const searchParams = new URLSearchParams(source("u1.1")); | ||
| sink(searchParams.get("x")); // $ hasTaintFlow=u1.1 | ||
| sink(searchParams.get(unknown())); // $ hasTaintFlow=u1.1 | ||
| sink(searchParams.getAll("x")); // $ hasTaintFlow=u1.1 | ||
| sink(searchParams.getAll(unknown())); // $ hasTaintFlow=u1.1 | ||
| } | ||
|
|
||
| function u2() { | ||
| const url = new URL(source("u2.1")); | ||
| sink(url.searchParams.get("x")); // $ hasTaintFlow=u2.1 | ||
| sink(url.searchParams.get(unknown())); // $ hasTaintFlow=u2.1 | ||
| sink(url.searchParams.getAll("x")); // $ hasTaintFlow=u2.1 | ||
| sink(url.searchParams.getAll(unknown())); // $ hasTaintFlow=u2.1 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.