Skip to content

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 24, 2025

In this PR we

  • Update the generated stubs.
  • Add some manual models to some of the new params ReadOnlySpan<...> method overloads.

Added some extra projects due to prior breaking changes in .NET

@github-actions github-actions bot added the C# label Jan 24, 2025
@michaelnebel michaelnebel force-pushed the csharp/updatestubs branch 4 times, most recently from 7a5c30b to 98062c9 Compare January 27, 2025 12:37
@github-actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",47,10819,54,5
+    System,"``System.*``, ``System``",47,10864,54,5
-    Totals,,108,12901,400,9
+    Totals,,108,12946,400,9
  • Changes to framework-coverage-csharp.csv:
- System,54,47,10819,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5512,5307
+ System,54,47,10864,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5547,5317

@michaelnebel
Copy link
Contributor Author

DCA looks good.

@michaelnebel michaelnebel marked this pull request as ready for review January 29, 2025 12:30
Copilot AI review requested due to automatic review settings January 29, 2025 12:30
@michaelnebel michaelnebel requested a review from a team as a code owner January 29, 2025 12:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 369 out of 369 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@@ -3285,41 +3323,6 @@ summary
| Microsoft.VisualBasic;VBCodeProvider;VBCodeProvider;(System.Collections.Generic.IDictionary<System.String,System.String>);Argument[0].Element;Argument[this];taint;df-generated |
| Microsoft.Win32.SafeHandles;SafeFileHandle;SafeFileHandle;(System.IntPtr,System.Boolean);Argument[0];Argument[this].Field[System.Runtime.InteropServices.SafeHandle.handle];value;dfc-generated |
| Microsoft.Win32.SafeHandles;SafeWaitHandle;SafeWaitHandle;(System.IntPtr,System.Boolean);Argument[0];Argument[this].Field[System.Runtime.InteropServices.SafeHandle.handle];value;dfc-generated |
| Microsoft.Win32;PowerModeChangedEventHandler;BeginInvoke;(System.Object,Microsoft.Win32.PowerModeChangedEventArgs,System.AsyncCallback,System.Object);Argument[2];Argument[2].Parameter[delegate-self];value;hq-generated |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected that we loose so many rows?

Copy link
Contributor Author

@michaelnebel michaelnebel Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because some of dependencies have changed such that System.Windows.Extensions is no longer referenced in the updated versions of the packages. If this is of concern, I can take a look and see whether se should try to explicitly include these packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some extra dependencies. Maybe that is for the best. It will also be interesting to see what happens when we re-generate the models for .NET (for .NET 9).
Awaiting CI before setting ready for review again.

@michaelnebel michaelnebel marked this pull request as draft January 30, 2025 15:32
@michaelnebel michaelnebel marked this pull request as ready for review January 31, 2025 10:03
@michaelnebel michaelnebel requested a review from hvitved January 31, 2025 10:03
@michaelnebel michaelnebel merged commit e39ad94 into github:main Feb 3, 2025
20 checks passed
@michaelnebel michaelnebel deleted the csharp/updatestubs branch February 3, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants