JS: Add Angular2 DOM sources #18458
Merged
JS: Add Angular2 DOM sources #18458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (4)
- javascript/ql/lib/semmle/javascript/DOM.qll: Language not supported
- javascript/ql/lib/semmle/javascript/frameworks/Angular2.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomCustomizations.qll: Language not supported
- javascript/ql/test/query-tests/Security/CWE-079/XssThroughDom/XssThroughDom.expected: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
erik-krogh
previously approved these changes
Jan 10, 2025
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
👍
Optional comment about the tests.
| } | ||
|
|
||
| useField() { | ||
| document.write(this.field); // NOT OK |
Contributor
There was a problem hiding this comment.
maybe add a negative example?
Add a field name otherField and test that it's safe.
Similarly a setOtherInput(..) method where the parameter is safe to use.
asgerf
force-pushed
the
js/angular2-xss-through-dom
branch
from
19f8d62 to
2c65946
Compare
Contributor
Author
|
Rebased on main as there were many conflicts in the |
erik-krogh
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a few sources of form inputs and DOM objects coming from Angular:
$eventinside an Angular event handler as a source of DOM eventsNgForm.valueas a source of form input[(ngModel)]two-way data binding as a source of form input