-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Go: Add models for standard library updates in Go 1.24 #18454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2806e07
Model additions to `encoding` in Go 1.24
owen-mc 79232da
Add models for `weak` package, added in Go 1.24
owen-mc eac7703
Update go version required for stdlib tests
owen-mc 01ea4bd
Add change note
owen-mc 2762272
Pretty-print models in a test
owen-mc dbad4df
Update change note
owen-mc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * Taint models have been added for the `weak` package, added in Go 1.24. | ||
| * Taint models have been added for the interfaces `TextAppender` and `BinaryAppender` in the `encoding` package, which were added in Go 1.24. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/go-all | ||
| extensible: summaryModel | ||
| data: | ||
| - ["weak", "", False, "Make", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"] | ||
| - ["weak", "Pointer", False, "Value", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
go/ql/test/library-tests/semmle/go/frameworks/BeegoOrm/StoredXss.qlref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| Security/CWE-079/StoredXss.ql | ||
| query: Security/CWE-079/StoredXss.ql | ||
| postprocess: utils/test/PrettyPrintModels.ql |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/Weak.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package main | ||
|
|
||
| import "weak" | ||
|
|
||
| func TaintStepTest_WeakMake_manual(sourceCQL interface{}) interface{} { | ||
| fromStringPointer := sourceCQL.(*string) | ||
| intoWeakPointer := weak.Make(fromStringPointer) | ||
| return intoWeakPointer | ||
| } | ||
| func TaintStepTest_WeakValue_manual(sourceCQL interface{}) interface{} { | ||
| fromWeakPointer := sourceCQL.(weak.Pointer[string]) | ||
| intoStringPointer := fromWeakPointer.Value() | ||
| return intoStringPointer | ||
| } | ||
|
|
||
| func RunAllTaints_Weak() { | ||
| { | ||
| source := newSource(0) | ||
| out := TaintStepTest_WeakMake_manual(source) | ||
| sink(0, out) | ||
| } | ||
| { | ||
| source := newSource(1) | ||
| out := TaintStepTest_WeakValue_manual(source) | ||
| sink(1, out) | ||
| } | ||
| } |
2 changes: 1 addition & 1 deletion
2
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/go.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module example.com/m | ||
|
|
||
| go 1.23 | ||
| go 1.24 | ||
|
|
||
| require ( | ||
| golang.org/x/net v0.0.0-20201010224723-4f7140c49acb | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.