Revert two Go PRs #18434
Merged
Revert two Go PRs #18434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2025 14:55
Contributor
There was a problem hiding this comment.
Copilot reviewed 16 out of 31 changed files in this pull request and generated no comments.
Files not reviewed (15)
- go/ql/lib/semmle/go/dataflow/internal/ContainerFlow.qll: Language not supported
- go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll: Language not supported
- go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll: Language not supported
- go/ql/lib/semmle/go/dataflow/internal/TaintTrackingUtil.qll: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/ExternalValueFlow/completetest.ql: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalTaintStep.expected: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/VarArgsWithExternalFlow/Flows.expected: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/VarArgsWithExternalFlow/Flows.ext.yml: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/VarArgsWithExternalFlow/Flows.ql: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/VarArgsWithExternalFlow/go.mod: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/VarArgsWithFunctionModels/Flows.ql: Language not supported
- go/ql/test/library-tests/semmle/go/dataflow/VarArgsWithFunctionModels/go.mod: Language not supported
- go/ql/test/library-tests/semmle/go/frameworks/BeegoOrm/StoredXss.expected: Language not supported
- go/ql/test/library-tests/semmle/go/frameworks/TaintSteps/TaintStep.expected: Language not supported
- go/ql/test/query-tests/Security/CWE-078/StoredCommand.expected: Language not supported
Comments suppressed due to low confidence (1)
go/ql/test/library-tests/semmle/go/dataflow/VarArgsWithFunctionModels/main.go:11
- Changing the parameter type of the
sinkfunction fromanytostringcould lead to runtime errors if non-string values are passed to it. Ensure that this change is covered by tests.
func sink(string) {
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
smowton
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #18275 and #18235, which were causing regressions during 2.20.1 testing