Skip to content

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Dec 26, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Dec 26, 2024
@jketema jketema changed the base branch from main to jketema/template-parameters-6 December 26, 2024 11:32
@jketema jketema force-pushed the jketema/template-parameters-7 branch from 09c0791 to 56b3e70 Compare December 26, 2024 16:35
@jketema jketema force-pushed the jketema/template-parameters-6 branch from a77b8f6 to 347edc4 Compare January 9, 2025 12:27
Base automatically changed from jketema/template-parameters-6 to main January 9, 2025 21:21
@jketema jketema force-pushed the jketema/template-parameters-7 branch from bf19755 to bf7dd9b Compare January 9, 2025 22:58
@jketema jketema force-pushed the jketema/template-parameters-7 branch from bf7dd9b to 0a292fb Compare January 10, 2025 09:21
@jketema jketema marked this pull request as ready for review January 10, 2025 09:28
Copilot AI review requested due to automatic review settings January 10, 2025 09:28
@jketema jketema requested a review from a team as a code owner January 10, 2025 09:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • cpp/downgrades/dd32242a870867a532bb0b2a88a6a917a5b4c26f/upgrade.properties: Language not supported
  • cpp/ql/lib/semmle/code/cpp/Function.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/TemplateParameter.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/UserType.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/Variable.qll: Language not supported
  • cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
  • cpp/ql/lib/upgrades/1a4bbe5ded083b9de87911c155fc99ca22ecb0ce/upgrade.properties: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

predicate isNoExcept() { fun_decl_empty_noexcept(underlyingElement(this)) }

/**
* Gets a requires clause if this declaration is a template with such a clause.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally fine with the text, but sometimes if this declaration is a template with such a clause can be written as , if any.

@jketema jketema merged commit 8c3e5b6 into main Jan 10, 2025
16 checks passed
@jketema jketema deleted the jketema/template-parameters-7 branch January 10, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants