Ruby: enable diff-informed data flow queries #18337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
❤️ |
asgerf
force-pushed
the
rb/diff-informed
branch
from
6fdd765 to
583c703
Compare
asgerf
force-pushed
the
rb/diff-informed
branch
from
583c703 to
772c336
Compare
This reverts commit 772c336.
Contributor
There was a problem hiding this comment.
Copilot reviewed 32 out of 52 changed files in this pull request and generated no comments.
Files not reviewed (20)
- ruby/ql/lib/codeql/ruby/experimental/UnicodeBypassValidationQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/experimental/ZipSlipQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/Excon.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/Faraday.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/HttpClient.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/Httparty.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/NetHttp.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/OpenURI.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/RestClient.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/http_clients/Typhoeus.qll: Language not supported
- ruby/ql/lib/codeql/ruby/frameworks/stdlib/Pathname.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/CleartextLoggingQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/CleartextStorageQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/CodeInjectionQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/CommandInjectionQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/ConditionalBypassQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/HardcodedDataInterpretedAsCodeQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/HttpToFileAccessQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/ImproperLdapAuthQuery.qll: Language not supported
- ruby/ql/lib/codeql/ruby/security/InsecureDownloadQuery.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is an auto-generated patch that enables diff-informed data flow in the obvious cases, and inserts a TODO comment in the non-obvious cases.
Those TODOs are then fixed up in the second commit.
Evaluation shows up to 63% speedup, with a median of 18% speedup.