CI: fix rust formatting #18328
Merged
CI: fix rust formatting #18328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo fmt --all` should be avoided in CI as that will include `rust/ast-generator` which has sources provided by bazel (`bazel run //rust/ast-generator:inject_sources` can provide those sources in-tree). Now the formatting checks are limited to the sources that trigger the jobs, and a check is added to `rust/ast-generator`.
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
aibaars
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmt --allshould be avoided in non-rust extractor CI checks as that will includerust/ast-generatorwhich has sources provided by bazel (bazel run //rust/ast-generator:inject_sourcescan provide those sources in-tree).Now the formatting checks are limited to the sources that trigger the jobs, and a check is added to
rust/ast-generator.