Rust: distinguish [a, b] from [a; b]
#18190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the `ArrayExpr` class into `ArrayListExpr` and `ArrayRepeatExpr`. This uses the `synth.from_class` machinery to integrate seamlessly into the generated code, by hiding the extracted `ArrayExpr` behind an internal class and replacing it with a hierarchy of those two classes under a new `ArrayExpr` class.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| private import internal.ArrayRepeatExprImpl | ||
| import codeql.rust.elements.ArrayExpr | ||
| import codeql.rust.elements.Expr |
Check warning
Code scanning / CodeQL
Redundant import Warning
paldepind
reviewed
Dec 3, 2024
| /** | ||
| * Gets the `index`th attr of this array expression (0-based). | ||
| */ | ||
| Attr getAttr(int index) { |
Contributor
There was a problem hiding this comment.
Did we loose the predicates to get attributes on ArrayExpr? Or are they somehow still there in some way I'm not seeing.
Contributor
Author
There was a problem hiding this comment.
ah, no, it's me that I forgot
paldepind
approved these changes
Dec 3, 2024
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Thanks for improving this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the
ArrayExprclass intoArrayListExprandArrayRepeatExpr. This uses thesynth.from_classmachinery to integrate seamlessly into the generated code, by hiding the extractedArrayExprbehind an internal class and replacing it with a synthesized hierarchy of those two classes under a newArrayExprclass.