Java: fix unreachable basic blocks in const switch stmt #17988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 15, 2024
This is unrelated to the main purpose of this PR. I have made a separate PR to do it here: github#17988
aschackmull
approved these changes
Nov 18, 2024
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
LGTM. Although, the UnreachableBlocks library might be dead code, IIRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was fixed in passing in #711, but unfortunately that PR wasn't merged for performance reasons. It hasn't been noticed in the meantime, presumably because constant switch statements are pretty rare.