Rust: Include patterns as data flow nodes #17971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| /** A data flow node that corresponds to a CFG node for an AST node. */ | ||
| abstract private class AstCfgFlowNode extends Node { |
Check warning
Code scanning / CodeQL
UnusedField Warning
Contributor
Author
There was a problem hiding this comment.
Not sure if this is a real problem. n is used in one of the predicates in AstCfgFlowNode and the subclasses do bind it.
Contributor
There was a problem hiding this comment.
You may be able to suppress it with something like
bindingset[this, n]
AstCfgFlowNode() { exists(this) and exists(n) }
hvitved
approved these changes
Nov 19, 2024
| } | ||
|
|
||
| /** A data flow node that corresponds to a CFG node for an AST node. */ | ||
| abstract private class AstCfgFlowNode extends Node { |
Contributor
There was a problem hiding this comment.
You may be able to suppress it with something like
bindingset[this, n]
AstCfgFlowNode() { exists(this) and exists(n) }
Comment on lines
+293
to
+296
| exists(LetStmt s | | ||
| nodeFrom.getCfgNode().getAstNode() = s.getInitializer() and | ||
| nodeTo.getCfgNode().getAstNode() = s.getPat() | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds patterns as data flow nodes.
Also adds flow from the rhs. of a
letstatement to the lhs. which depends on patterns being in the data flow nodes. That will need some tweaking once we have the CFG layer over the AST layer.Adds an abstract class for data flow node that corresponds to a CFG nodes for a AST nodes to factor out some common code.