JS: Support for matchAll #17910
Merged
JS: Support for matchAll #17910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
reviewed
Nov 5, 2024
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
A small suggestion, otherwise LGTM assuming the evaluations look good.
I think we should also look at MembershipCandidates.qll and TaintTracking.qll.
But lets do that in a followup PR.
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
Napalys
force-pushed
the
napalys/matchAll-support
branch
from
93c2dad to
810eddc
Compare
Napalys
force-pushed
the
napalys/matchAll-support
branch
from
810eddc to
449cee9
Compare
Napalys
force-pushed
the
napalys/matchAll-support
branch
from
d7dab8b to
bca14d7
Compare
Napalys
force-pushed
the
napalys/matchAll-support
branch
2 times, most recently
from
9809499 to
a96f9fc
Compare
Napalys
force-pushed
the
napalys/matchAll-support
branch
from
a96f9fc to
a4fe728
Compare
erik-krogh
reviewed
Nov 11, 2024
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
Looks good 👍
Just one small comment.
javascript/ql/test/experimental/Security/CWE-918/check-regex.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
Contributor
|
Is there a DCA run with all the changes? But it looks like they're only for the first half of the PR. Could you start one with source-suite: nightly-old, query-suite: code-scanning, and add |
Contributor
Author
|
DCA experiment looks good, no new unexpected sinks. |
erik-krogh
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ES2020 feature, matchAll.
Related issue: github/codeql-javascript-team/issues/435