Rust: Exclude results inside macro expansions from unused entity queries #17865
Conversation
github-actions
bot
added
C#
JS
C++
Java
Python
Go
Ruby
Rust
hvitved
force-pushed
the
rust/unused-macro-expansion
branch
from
186ff94 to
072b836
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
hvitved
force-pushed
the
rust/unused-macro-expansion
branch
from
072b836 to
2a68d6d
Compare
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Looks great!
One question, for my education.
We need to wait for the underlying PR to be merged, and probably do a DCA run.
| * Gets the nearest enclosing parent of this node, which is also an `AstNode`, | ||
| * if any. | ||
| */ | ||
| AstNode getParentNode() { result = getParentOfAstStep*(getImmediateParent(this)) } |
There was a problem hiding this comment.
I'd prefer getParent . I think all immediate parents are actually AstNodes, and if not, we should probably change the schema.
There was a problem hiding this comment.
I can't be named getParent because it will then conflict with the auto-generated Comment.getParent predicate :-(
hvitved
force-pushed
the
rust/unused-macro-expansion
branch
from
bd2e98c to
d0f9a0b
Compare
| &mut self, | ||
| times: i32, | ||
| unused: i32, // $ Alert[rust/unused-variable] | ||
| unused: &mut i32, // $ Alert[rust/unused-variable] |
Check notice
Code scanning / CodeQL
Unused variable Note test
| // --- macros --- | ||
|
|
||
| fn macros() { | ||
| let x; |
Check notice
Code scanning / CodeQL
Unused variable Note test
3 participants
No description provided.