Skip to content

Commit b7557e6

Browse files
committed
Fix editing error to make valid QL
1 parent f54f73a commit b7557e6

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

java/ql/lib/semmle/code/java/security/ArithmeticUncontrolledQuery.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ module ArithmeticUncontrolledOverflowFlow =
4343
module ArithmeticUncontrolledUnderflowConfig implements DataFlow::ConfigSig {
4444
predicate isSource(DataFlow::Node source) { source instanceof TaintSource }
4545

46-
underflowBarrier(n) or
47-
barrierNode(n, "java/uncontrolled-arithmetic")
48-
4946
predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }
5047

51-
predicate isBarrier(DataFlow::Node n) { underflowBarrier(n) }
48+
predicate isBarrier(DataFlow::Node n) {
49+
underflowBarrier(n) or
50+
barrierNode(n, "java/uncontrolled-arithmetic")
51+
}
5252

5353
predicate observeDiffInformedIncrementalMode() {
5454
any() // merged with ArithmeticUncontrolledOverflow in ArithmeticUncontrolled.ql

java/ql/lib/semmle/code/java/security/ArithmeticWithExtremeValuesQuery.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ module MinValueFlowConfig implements DataFlow::ConfigSig {
5656

5757
predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }
5858

59-
underflowBarrier(n) or
60-
barrierNode(n, "java/extreme-value-arithmetic")
61-
6259
predicate isBarrierIn(DataFlow::Node n) { isSource(n) }
6360

64-
predicate isBarrier(DataFlow::Node n) { underflowBarrier(n) }
61+
predicate isBarrier(DataFlow::Node n) {
62+
underflowBarrier(n) or
63+
barrierNode(n, "java/extreme-value-arithmetic")
64+
}
6565
}
6666

6767
/** Dataflow from minimum values to an underflow. */

0 commit comments

Comments
 (0)