Skip to content

Commit f54f73a

Browse files
committed
Make imports private
1 parent 2e6d9e6 commit f54f73a

File tree

50 files changed

+53
-54
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+53
-54
lines changed

java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import java
44
import semmle.code.java.dataflow.FlowSources
55
import semmle.code.java.dataflow.TaintTracking
66
import semmle.code.java.security.AndroidIntentRedirection
7-
import semmle.code.java.dataflow.ExternalFlow
7+
private import semmle.code.java.dataflow.ExternalFlow
88

99
/** A taint tracking configuration for tainted Intents being used to start Android components. */
1010
module IntentRedirectionConfig implements DataFlow::ConfigSig {

java/ql/lib/semmle/code/java/security/AndroidSensitiveCommunicationQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import java
44
import semmle.code.java.dataflow.TaintTracking
55
import semmle.code.java.frameworks.android.Intent
66
import semmle.code.java.security.SensitiveActions
7+
private import semmle.code.java.dataflow.ExternalFlow
78
private import semmle.code.java.dataflow.FlowSinks
8-
import semmle.code.java.dataflow.ExternalFlow
99

1010
/**
1111
* Gets regular expression for matching names of Android variables that indicate the value being held contains sensitive information.

java/ql/lib/semmle/code/java/security/ArbitraryApkInstallationQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import java
44
import semmle.code.java.dataflow.DataFlow
55
import semmle.code.java.dataflow.TaintTracking
6+
private import semmle.code.java.dataflow.ExternalFlow
67
private import semmle.code.java.security.ArbitraryApkInstallation
7-
import semmle.code.java.dataflow.ExternalFlow
88

99
/**
1010
* A dataflow configuration for flow from an external source of an APK to the

java/ql/lib/semmle/code/java/security/ArithmeticTaintedQuery.qll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/** Provides taint-tracking configurations to reason about arithmetic with unvalidated input. */
22

33
import java
4+
private import semmle.code.java.dataflow.ExternalFlow
45
private import semmle.code.java.dataflow.FlowSources
56
private import semmle.code.java.security.ArithmeticCommon
6-
import semmle.code.java.dataflow.ExternalFlow
77

88
/** A taint-tracking configuration to reason about overflow from unvalidated input. */
99
module ArithmeticOverflowConfig implements DataFlow::ConfigSig {
@@ -38,12 +38,12 @@ deprecated module RemoteUserInputOverflowConfig = ArithmeticOverflowConfig;
3838
module ArithmeticUnderflowConfig implements DataFlow::ConfigSig {
3939
predicate isSource(DataFlow::Node source) { source instanceof ActiveThreatModelSource }
4040

41-
underflowBarrier(n) or
42-
barrierNode(n, "java/tainted-arithmetic")
43-
4441
predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }
4542

46-
predicate isBarrier(DataFlow::Node n) { underflowBarrier(n) }
43+
predicate isBarrier(DataFlow::Node n) {
44+
underflowBarrier(n) or
45+
barrierNode(n, "java/tainted-arithmetic")
46+
}
4747

4848
predicate isBarrierIn(DataFlow::Node node) { isSource(node) }
4949

java/ql/lib/semmle/code/java/security/ArithmeticUncontrolledQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
/** Provides taint-tracking configuration to reason about arithmetic with uncontrolled values. */
22

33
import java
4+
private import semmle.code.java.dataflow.ExternalFlow
45
private import semmle.code.java.dataflow.TaintTracking
56
private import semmle.code.java.security.RandomQuery
67
private import semmle.code.java.security.SecurityTests
78
private import semmle.code.java.security.ArithmeticCommon
8-
import semmle.code.java.dataflow.ExternalFlow
99

1010
private class TaintSource extends DataFlow::ExprNode {
1111
TaintSource() {

java/ql/lib/semmle/code/java/security/ArithmeticWithExtremeValuesQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/** Provides predicates and classes for reasoning about arithmetic with extreme values. */
22

33
import java
4+
private import semmle.code.java.dataflow.ExternalFlow
45
private import semmle.code.java.dataflow.DataFlow
56
private import semmle.code.java.security.ArithmeticCommon
6-
import semmle.code.java.dataflow.ExternalFlow
77

88
/**
99
* A field representing an extreme value.

java/ql/lib/semmle/code/java/security/BrokenCryptoAlgorithmQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import java
44
private import semmle.code.java.security.Encryption
5+
private import semmle.code.java.dataflow.ExternalFlow
56
private import semmle.code.java.dataflow.TaintTracking
67
private import semmle.code.java.security.Sanitizers
7-
import semmle.code.java.dataflow.ExternalFlow
88

99
private class ShortStringLiteral extends StringLiteral {
1010
ShortStringLiteral() { this.getValue().length() < 100 }

java/ql/lib/semmle/code/java/security/ConditionalBypassQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import java
77
import semmle.code.java.dataflow.FlowSources
88
import semmle.code.java.security.SensitiveActions
99
import semmle.code.java.controlflow.Guards
10-
import semmle.code.java.dataflow.ExternalFlow
10+
private import semmle.code.java.dataflow.ExternalFlow
1111

1212
/**
1313
* Holds if `ma` is controlled by the condition expression `e`.

java/ql/lib/semmle/code/java/security/ExternalAPIs.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module;
88
import java
99
import semmle.code.java.dataflow.FlowSources
1010
import semmle.code.java.dataflow.TaintTracking
11-
import semmle.code.java.dataflow.ExternalFlow
11+
private import semmle.code.java.dataflow.ExternalFlow
1212

1313
/**
1414
* A `Method` that is considered a "safe" external API from a security perspective.

java/ql/lib/semmle/code/java/security/ExternallyControlledFormatStringQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/** Provides a taint-tracking configuration to reason about externally controlled format string vulnerabilities. */
22

33
import java
4+
private import semmle.code.java.dataflow.ExternalFlow
45
private import semmle.code.java.dataflow.FlowSinks
56
private import semmle.code.java.dataflow.FlowSources
67
private import semmle.code.java.StringFormat
7-
import semmle.code.java.dataflow.ExternalFlow
88

99
/**
1010
* A string format sink node.

0 commit comments

Comments
 (0)