Merge pull request #9145 from tamasvajk/kotlin-useless-param

Kotlin: Respect `override` modifier in useless parameter query

Author: tamasvajk

java/ql/lib/semmle/code/java/deadcode/DeadCode.qll

@@ -302,6 +302,8 @@ class RootdefCallable extends Callable {
     exists(MemberRefExpr mre | mre.getReferencedCallable() = this)
     or
     this.getAnAnnotation() instanceof OverrideAnnotation
+    or
+    this.hasModifier("override")
   }
 }
 

java/ql/test/kotlin/query-tests/UselessParameter/Test.kt

@@ -0,0 +1,9 @@
+interface A<T, V> {
+    fun setValue(a: T, b: V)
+}
+
+class B : A<B, Int> {
+    override fun setValue(a: B, b: Int) {
+        println("a")
+    }
+}

java/ql/test/kotlin/query-tests/UselessParameter/UselessParameter.expected

@@ -0,0 +1 @@
+DeadCode/UselessParameter.ql